Skip to content

fix incorrect deserialization of some legacy formats #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix incorrect deserialization of some legacy formats #49

wants to merge 1 commit into from

Conversation

@atogata
Copy link

@atogata atogata commented Dec 20, 2022 •
edited by hsbt
Loading

In at least some cases, the legacy format includes an additional field that needs to be considered.

# ruby 2.6.10p210 (2022-04-12 revision 67958) [universal.x86_64-darwin22]
require "ostruct"
require "yaml"
os = OpenStruct.new
os.a = 'b'
YAML.dump(os)

# => "--- !ruby/object:OpenStruct\ntable:\n  :a: b\nmodifiable: true\n"

@atogata
fix incorrect deserialization of some legacy formats
b0a934b 
```
In at least some cases, the legacy format includes an additional field that needs to be considered.

# ruby 2.6.10p210 (2022-04-12 revision 67958) [universal.x86_64-darwin22]

require "ostruct"
require "yaml"
os = OpenStruct.new
os.a = 'b'
YAML.dump(os)

# => "--- !ruby/object:OpenStruct\ntable:\n  🅰️ b\nmodifiable: true\n"
```
@atogata atogata force-pushed the fix-deserialization-issue branch from 431bfe2 to b0a934b Compare December 20, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@atogata